[PATCH net-next] sfc: remove unused variable 'efx_default_channel_type'
Subsystems:
networking drivers , sfc network driver , the rest
STALE2395d
5 messages,
3 authors,
2020-02-20 · open the first message on its own page
drivers/net/ethernet/sfc/efx.c:116:38: warning:
efx_default_channel_type defined but not used [-Wunused-const-variable=]
commit 83975485077d ("sfc: move channel alloc/removal code")
left behind this, remove it.
Reported-by: Hulk Robot <redacted>
Signed-off-by: YueHaibing <redacted>
---
drivers/net/ethernet/sfc/efx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 4481f21a1f43..256807c28ff7 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
*
*************************************************************************/
- static const struct efx_channel_type efx_default_channel_type ;
static void efx_remove_port ( struct efx_nic * efx );
static int efx_xdp_setup_prog ( struct efx_nic * efx , struct bpf_prog * prog );
static int efx_xdp ( struct net_device * dev , struct netdev_bpf * xdp ); --
2.20.1
On 11/02/2020 14:16, YueHaibing wrote: drivers/net/ethernet/sfc/efx.c:116:38: warning:
efx_default_channel_type defined but not used [-Wunused-const-variable=]
This is a good fix, but net-next is closed at the moment. Please resubmit it when it reopens.
commit 83975485077d ("sfc: move channel alloc/removal code")
left behind this, remove it.
Please add this info with a "Fixes:" tag.
Thanks,
Martin
quoted hunk
Reported-by: Hulk Robot <redacted>
Signed-off-by: YueHaibing <redacted>
---
drivers/net/ethernet/sfc/efx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 4481f21a1f43..256807c28ff7 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
*
*************************************************************************/
- static const struct efx_channel_type efx_default_channel_type ;
static void efx_remove_port ( struct efx_nic * efx );
static int efx_xdp_setup_prog ( struct efx_nic * efx , struct bpf_prog * prog );
static int efx_xdp ( struct net_device * dev , struct netdev_bpf * xdp );
drivers/net/ethernet/sfc/efx.c:116:38: warning:
efx_default_channel_type defined but not used [-Wunused-const-variable=]
commit 83975485077d ("sfc: move channel alloc/removal code")
left behind this, remove it.
Reported-by: Hulk Robot <redacted>
Fixes: 83975485077d ("sfc: move channel alloc/removal code")
Signed-off-by: YueHaibing <redacted>
---
v2: Add Fixes tag
---
drivers/net/ethernet/sfc/efx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 4481f21..256807c 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
*
*************************************************************************/
- static const struct efx_channel_type efx_default_channel_type ;
static void efx_remove_port ( struct efx_nic * efx );
static int efx_xdp_setup_prog ( struct efx_nic * efx , struct bpf_prog * prog );
static int efx_xdp ( struct net_device * dev , struct netdev_bpf * xdp ); --
2.7.4
On 19/02/2020 01:34, YueHaibing wrote: drivers/net/ethernet/sfc/efx.c:116:38: warning:
efx_default_channel_type defined but not used [-Wunused-const-variable=]
commit 83975485077d ("sfc: move channel alloc/removal code")
left behind this, remove it.
Reported-by: Hulk Robot <redacted>
Fixes: 83975485077d ("sfc: move channel alloc/removal code")
Signed-off-by: YueHaibing <redacted>
Acked-by: Martin Habets <redacted>
quoted hunk ---
v2: Add Fixes tag
---
drivers/net/ethernet/sfc/efx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 4481f21..256807c 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
*
*************************************************************************/
- static const struct efx_channel_type efx_default_channel_type ;
static void efx_remove_port ( struct efx_nic * efx );
static int efx_xdp_setup_prog ( struct efx_nic * efx , struct bpf_prog * prog );
static int efx_xdp ( struct net_device * dev , struct netdev_bpf * xdp );
From: YueHaibing <redacted>
Date: Wed, 19 Feb 2020 09:34:58 +0800
drivers/net/ethernet/sfc/efx.c:116:38: warning:
efx_default_channel_type defined but not used [-Wunused-const-variable=]
commit 83975485077d ("sfc: move channel alloc/removal code")
left behind this, remove it.
Reported-by: Hulk Robot <redacted>
Fixes: 83975485077d ("sfc: move channel alloc/removal code")
Signed-off-by: YueHaibing <redacted>
---
v2: Add Fixes tag
Applied, thanks.