[PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check

Subsystems: bpf [general] (safe dynamic programs and tools), bpf [tooling] (bpftool), the rest

STALE2408d LANDED

Landed in mainline as a525b0881de7 on 2020-02-03.

3 messages, 3 authors, 2020-02-03 · open the first message on its own page

[PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check

From: Michal Rostecki <hidden>
Date: 2020-02-02 11:01:24

"HAVE" prefix is already applied by default to feature macros and before
this change, the large INSN limit macro had the incorrect name with
double "HAVE".

Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
Signed-off-by: Michal Rostecki <redacted>
---
 tools/bpf/bpftool/feature.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
index 446ba891f1e2..941873d778d8 100644
--- a/tools/bpf/bpftool/feature.c
+++ b/tools/bpf/bpftool/feature.c
@@ -580,7 +580,7 @@ probe_large_insn_limit(const char *define_prefix, __u32 ifindex)
 	res = bpf_probe_large_insn_limit(ifindex);
 	print_bool_feature("have_large_insn_limit",
 			   "Large program size limit",
-			   "HAVE_LARGE_INSN_LIMIT",
+			   "LARGE_INSN_LIMIT",
 			   res, define_prefix);
 }
 
-- 
2.16.4

Re: [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check

From: Yonghong Song <hidden>
Date: 2020-02-02 20:00:12


On 2/2/20 3:02 AM, Michal Rostecki wrote:
"HAVE" prefix is already applied by default to feature macros and before
this change, the large INSN limit macro had the incorrect name with
double "HAVE".

Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
Signed-off-by: Michal Rostecki <redacted>
Acked-by: Yonghong Song <redacted>

Re: [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2020-02-03 23:10:30

On 2/2/20 12:02 PM, Michal Rostecki wrote:
"HAVE" prefix is already applied by default to feature macros and before
this change, the large INSN limit macro had the incorrect name with
double "HAVE".

Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
Signed-off-by: Michal Rostecki <redacted>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help