DORMANTno replies REVIEWED: 1 (1M)

1 review trailer.

[PATCH v3] slip: not call free_netdev before rtnl_unlock in slip_open

From: yangerkun <hidden>
Date: 2020-02-26 12:10:55
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.

Signed-off-by: yangerkun <redacted>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
 drivers/net/slip/slip.c | 2 ++
 1 file changed, 2 insertions(+)

v2->v3:
delete comment exist in v2
diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
index 6f4d7ba8b109..0d2d8c78635e 100644
--- a/drivers/net/slip/slip.c
+++ b/drivers/net/slip/slip.c
@@ -863,7 +863,9 @@ static int slip_open(struct tty_struct *tty)
 	tty->disc_data = NULL;
 	clear_bit(SLF_INUSE, &sl->flags);
 	sl_free_netdev(sl->dev);
+	rtnl_unlock();
 	free_netdev(sl->dev);
+	return err;
 
 err_exit:
 	rtnl_unlock();
-- 
2.23.0.rc2.8.gff66981f45
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help