# Re: \[PATCH v3 net 7/9\] ipvlan: remove skb\_share\_check from xmit path

- From: Jason A. Donenfeld \<Jason@zx2c4.com\>
- Date: 2020-02-11 17:44:37 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/02/11159893
- Thread: https://ratatoskr.run/netdev/2020/02/11159816/t.md

```text
On Tue, Feb 11, 2020 at 6:39 PM Eric Dumazet [ref] wrote:
> Yes, maybe, but can you elaborate in this changelog ?
>
> AFAIK net/core/pktgen.c can definitely provide shared skbs.
>
>      refcount_inc(&pkt_dev->skb->users);
>      ret = dev_queue_xmit(pkt_dev->skb);
>
> We might have to change pktgen to make sure we do not make skb shared
> just because it was convenient.
>
> Please do not give a link to some web page that might disappear in the future.
>
> Having to follow an old thread to understand the reasoning is not appealing
> for us having to fix bugs in the following years.

Well, I don't know really.

Florian said I should remove skb_share_check() from a function I was
adding, because according to him, the ndo_start_xmit path cannot
contain shared skbs. (See the 0/9 cover letter.) If this claim is
true, then this series is correct. If this claim is not true, then the
series needs to be adjusted.

I tried to trace these and couldn't totally make up my mind, hence the
ALL CAPS mention in the 0/9.

Do you know if this is a safe presumption to make? It sounds like your
opinion is "no" in light of pktgen.c? Should that simply be adjusted
instead?

Jason
```
