# Re: \[PATCH v2 net 1/5\] icmp: introduce helper for NAT'd source address in network device context

- From: Jason A. Donenfeld \<Jason@zx2c4.com\>
- Date: 2020-02-11 09:59:52 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/02/11159858
- Thread: https://ratatoskr.run/netdev/2020/02/11159816/t.md

```text
On Mon, Feb 10, 2020 at 11:33 PM Florian Westphal [ref] wrote:
> I think this is a bit too conservative, f.e. i don't see how
> ndo-called skbs could be shared (tx path needs to be able to change skb
> list pointers)?

Are you *sure* about that? Dave - do you know?

I'm asking with *asterisks* because I see a few drivers in tree that
do call skb_share_check from their ndo_start_xmit function. If this
makes no sense and isn't needed, then I'll send a cleanup series for
these. And, I'll remove it from icmp_ndo_send for v3, replacing it
with a `if (WARN_ON(skb_shared(skb_in))) return;`.

Thanks,
Jason
```
