# Re: \[PATCH v2 net 1/5\] icmp: introduce helper for NAT'd source address in network device context

- From: Jason A. Donenfeld \<Jason@zx2c4.com\>
- Date: 2020-02-10 19:48:23 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/02/11159837
- Thread: https://ratatoskr.run/netdev/2020/02/11159816/t.md

```text
On Mon, Feb 10, 2020 at 3:15 PM Jason A. Donenfeld [ref] wrote:
> +               ip_hdr(skb_in)->saddr = ct->tuplehash[0].tuple.src.u3.ip;
> +       }
> +       icmp_send(skb_in, type, code, info);

According to the comments in icmp_send, access to
ip_hdr(skb_in)->saddr requires first checking for `if
(skb_network_header(skb_in) < skb_in->head ||
(skb_network_header(skb_in) + sizeof(struct iphdr)) >
skb_tail_pointer(skb_in))` first to be safe. So, I'll fix this up for
v3, but will wait some time in case there are additional comments.

Jason
```
