Re: [PATCH v2 net] net: sched: prevent a use after free
From: Cong Wang <hidden>
Date: 2020-02-05 18:03:58
Also in:
kernel-janitors
On Wed, Feb 5, 2020 at 3:56 AM Dan Carpenter [off-list ref] wrote:
The bug is that we call kfree_skb(skb) and then pass "skb" to
qdisc_pkt_len(skb) on the next line, which is a use after free.
Also Cong Wang points out that it's better to delay the actual
frees until we drop the rtnl lock so we should use rtnl_kfree_skbs()
instead of kfree_skb().
Cc: Cong Wang <redacted>
Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler")
Signed-off-by: Dan Carpenter <redacted>Acked-by: Cong Wang <redacted> Thanks!