# Re: \[PATCH 1/2\] net: ethernet: ti: cpsw\_switchdev: fix unmet direct dependencies detected for NET\_SWITCHDEV

- From: Randy Dunlap \<rdunlap@infradead.org\>
- Date: 2019-12-04 21:26:25 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/12/5795796
- Thread: https://ratatoskr.run/netdev/2019/12/5795221/t.md

```text
On 12/4/19 9:45 AM, Grygorii Strashko wrote:
> Replace "select NET_SWITCHDEV" vs "depends on NET_SWITCHDEV" to fix Kconfig
> warning with CONFIG_COMPILE_TEST=y
> 
> WARNING: unmet direct dependencies detected for NET_SWITCHDEV
>   Depends on [n]: NET [=y] && INET [=n]
>   Selected by [y]:
>   - TI_CPSW_SWITCHDEV [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && (ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST [=y])
> 
> because TI_CPSW_SWITCHDEV blindly selects NET_SWITCHDEV even though
> INET is not set/enabled, while NET_SWITCHDEV depends on INET.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>  drivers/net/ethernet/ti/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 9170572346b5..a46f4189fde3 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -62,7 +62,7 @@ config TI_CPSW
>  config TI_CPSW_SWITCHDEV
>  	tristate "TI CPSW Switch Support with switchdev"
>  	depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST
> -	select NET_SWITCHDEV
> +	depends on NET_SWITCHDEV
>  	select TI_DAVINCI_MDIO
>  	select MFD_SYSCON
>  	select REGMAP
> 


-- 
~Randy

```
