[PATCH] net: gemini: add missed free_netdev

Subsystems: arm/cortina systems gemini arm architecture, networking drivers, the rest

STALE2449d

3 messages, 3 authors, 2019-11-16 · open the first message on its own page

[PATCH] net: gemini: add missed free_netdev

From: Chuhong Yuan <hidden>
Date: 2019-11-15 06:25:11

This driver forgets to free allocated netdev in remove like
what is done in probe failure.
Add the free to fix it.

Signed-off-by: Chuhong Yuan <redacted>
---
 drivers/net/ethernet/cortina/gemini.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
index e736ce2c58ca..a8f4c69252ff 100644
--- a/drivers/net/ethernet/cortina/gemini.c
+++ b/drivers/net/ethernet/cortina/gemini.c
@@ -2524,6 +2524,7 @@ static int gemini_ethernet_port_remove(struct platform_device *pdev)
 	struct gemini_ethernet_port *port = platform_get_drvdata(pdev);
 
 	gemini_port_remove(port);
+	free_netdev(port->netdev);
 	return 0;
 }
 
-- 
2.24.0

Re: [PATCH] net: gemini: add missed free_netdev

From: Linus Walleij <hidden>
Date: 2019-11-15 09:50:36

On Fri, Nov 15, 2019 at 7:25 AM Chuhong Yuan [off-list ref] wrote:
This driver forgets to free allocated netdev in remove like
what is done in probe failure.
Add the free to fix it.

Signed-off-by: Chuhong Yuan <redacted>
Looks correct!
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

Re: [PATCH] net: gemini: add missed free_netdev

From: David Miller <davem@davemloft.net>
Date: 2019-11-16 20:54:55

From: Chuhong Yuan <redacted>
Date: Fri, 15 Nov 2019 14:24:54 +0800
This driver forgets to free allocated netdev in remove like
what is done in probe failure.
Add the free to fix it.

Signed-off-by: Chuhong Yuan <redacted>
Applied and queued up for -stable, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help