# Re: \[PATCH net\] net: dsa: bcm\_sf2: Fix IMP setup for port different than 8

- From: David Miller \<davem@davemloft.net\>
- Date: 2019-11-01 22:09:13 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/11/5762887
- Thread: https://ratatoskr.run/netdev/2019/10/5762121/t.md

```text
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 31 Oct 2019 15:54:05 -0700

> Since it became possible for the DSA core to use a CPU port different
> than 8, our bcm_sf2_imp_setup() function was broken because it assumes
> that registers are applicable to port 8. In particular, the port's MAC
> is going to stay disabled, so make sure we clear the RX_DIS and TX_DIS
> bits if we are not configured for port 8.
> 
> Fixes: 9f91484f6fcc ("net: dsa: make "label" property optional for dsa2")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied and queued up for -stable.
```