# Re: \[PATCH v7 01/24\] mm/gup: pass flags arg to \_\_gup\_device\_\* functions

- From: John Hubbard \<jhubbard@nvidia.com\>
- Date: 2019-11-21 08:28:02 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/11/167360
- Thread: https://ratatoskr.run/bpf/2019/11/167331/t.md

```text
On 11/21/19 12:06 AM, Christoph Hellwig wrote:
> On Wed, Nov 20, 2019 at 11:13:31PM -0800, John Hubbard wrote:
>> A subsequent patch requires access to gup flags, so
>> pass the flags argument through to the __gup_device_*
>> functions.
>
> Looks fine, but why not fold this into the patch using the flags.

Yes, I'll do that.

>
> Also you can use up your full 73 chars per line in the commit log.
>

OK.

thanks,
-- 
John Hubbard
NVIDIA
```