# Re: \[PATCH v7 01/24\] mm/gup: pass flags arg to \_\_gup\_device\_\* functions

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2019-11-21 08:09:05 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/11/167349
- Thread: https://ratatoskr.run/bpf/2019/11/167331/t.md

```text
On Wed, Nov 20, 2019 at 11:13:31PM -0800, John Hubbard wrote:
> A subsequent patch requires access to gup flags, so
> pass the flags argument through to the __gup_device_*
> functions.

Looks fine, but why not fold this into the patch using the flags.

Also you can use up your full 73 chars per line in the commit log.
```