[PATCH] cfg80211: Fix memory leak in cfg80211_inform_single_bss_data
From: Navid Emamdoost <hidden>
Date: 2019-10-27 18:05:03
Also in:
linux-wireless, lkml
Subsystem:
802.11 (including cfg80211/nl80211), the rest · Maintainers:
Johannes Berg, Linus Torvalds
In the implementation of cfg80211_inform_single_bss_data() the allocated
memory for ies is leaked in case of an error. Release ies if
cfg80211_bss_update() fails.
Fixes: 06aa7afaaa21 ("cfg80211: add cfg80211_inform_bss")
Signed-off-by: Navid Emamdoost <redacted>
---
net/wireless/scan.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index aef240fdf8df..686eb227bcc3 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c@@ -1437,8 +1437,10 @@ cfg80211_inform_single_bss_data(struct wiphy *wiphy, signal_valid = abs(data->chan->center_freq - channel->center_freq) <= wiphy->max_adj_channel_rssi_comp; res = cfg80211_bss_update(wiphy_to_rdev(wiphy), &tmp, signal_valid, ts); - if (!res) + if (!res) { + kfree(ies); return NULL; + } if (channel->band == NL80211_BAND_60GHZ) { bss_type = res->pub.capability & WLAN_CAPABILITY_DMG_TYPE_MASK;
--
2.17.1