[PATCH v2 19/23] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32

Subsystems: networking drivers, the rest

STALE2487d

Revision v2 of 2 in this series.

2 messages, 2 authors, 2019-10-30 · open the first message on its own page

[PATCH v2 19/23] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32

From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Date: 2019-10-25 12:42:28 

Currently, QUICC_ENGINE depends on PPC32, so this in itself does not
change anything. In order to allow removing the PPC32 dependency from
QUICC_ENGINE and avoid allmodconfig build failures, add this explicit
dependency.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 drivers/net/ethernet/freescale/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index 6a7e8993119f..97d27c7740d4 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -75,6 +75,7 @@ config FSL_XGMAC_MDIO
 config UCC_GETH
 	tristate "Freescale QE Gigabit Ethernet"
 	depends on QUICC_ENGINE
+	depends on PPC32
 	select FSL_PQ_MDIO
 	select PHYLIB
 	---help---
-- 
2.23.0

Re: [PATCH v2 19/23] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32

From: Christophe Leroy <hidden>
Date: 2019-10-30 10:55:30 


Le 25/10/2019 à 14:40, Rasmus Villemoes a écrit :
quoted hunk
Currently, QUICC_ENGINE depends on PPC32, so this in itself does not
change anything. In order to allow removing the PPC32 dependency from
QUICC_ENGINE and avoid allmodconfig build failures, add this explicit
dependency.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
  drivers/net/ethernet/freescale/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index 6a7e8993119f..97d27c7740d4 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -75,6 +75,7 @@ config FSL_XGMAC_MDIO
  config UCC_GETH
  	tristate "Freescale QE Gigabit Ethernet"
  	depends on QUICC_ENGINE
+	depends on PPC32
I think it would be more obvious to have:
	depends on QUICC_ENGINE && PPC32

Christophe

  	select FSL_PQ_MDIO
  	select PHYLIB
  	---help---
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help