# Re: \[PATCH\] net: mscc: ocelot: add missing of\_node\_put after calling of\_get\_child\_by\_name

- From: Wen Yang \<hidden\>
- Date: 2019-10-17 05:40:28 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/10/5747666
- Thread: https://ratatoskr.run/netdev/2019/09/5728749/t.md

```text


On 2019/10/2 1:02 上午, David Miller wrote:
> From: Wen Yang <redacted>
> Date: Sun, 29 Sep 2019 14:54:24 +0800
>
>> of_node_put needs to be called when the device node which is got
>> from of_get_child_by_name finished using.
>> In both cases of success and failure, we need to release 'ports',
>> so clean up the code using goto.
>>
>> fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support")
>> Signed-off-by: Wen Yang <redacted>
>
> Applied.
>

Thank you for your comments.

We checked the code repository and found that both ‘Fixes’ and ‘fixes’ are being used, such as:

commit a53651ec93a8d7ab5b26c5390e0c389048b4b4b6
…
    net: ena: don't wake up tx queue when down
…
    fixes: 1738cd3ed342 (net: ena: Add a driver for Amazon Elastic Network Adapters (ENA))
…

And,

commit 1df379924304b687263942452836db1d725155df
…
    clk: consoldiate the __clk_get_hw() declarations
…

    Fixes: 59fcdce425b7 ("clk: Remove ifdef for COMMON_CLK in clk-provider.h")
    fixes: 73e0e496afda ("clkdev: Always allocate a struct clk and call __clk_get() w/ CCF")
…


It is also found that the sha1 following ‘Fixes:’ requires at least 12 digits.

So we plan to modify the checkpatch.pl script to check for these issues.


diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a85d719..ddcd2d0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2925,7 +2925,7 @@ sub process {
 		}

 # check for invalid commit id
-		if ($in_commit_log && $line =~ /(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) {
+		if ($in_commit_log && $line =~ /(\bcommit)\s+([0-9a-f]{6,40})\b/i) {
 			my $id;
 			my $description;
 			($id, $description) = git_commit_info($2, undef, undef);
@@ -2935,6 +2935,25 @@ sub process {
 			}
 		}

+# check for fixes tag
+		if ($in_commit_log && $line =~ /(^fixes:)\s+([0-9a-f]{6,40})\b/i) {
+			my $id;
+			my $description;
+			($id, $description) = git_commit_info($2, undef, undef);
+			if (!defined($id)) {
+				WARN("UNKNOWN_COMMIT_ID",
+				     "Unknown commit id '$2', maybe rebased or not pulled?\n" . $herecurr);
+			}
+			if ($1 ne "Fixes") {
+				WARN("FIXES_TAG_STYLE",
+				     "The fixes tag should be capitalized (Fixes:).\n" . $hereprev);
+			}
+			if (length($2) < 12) {
+				WARN("FIXES_TAG_STYLE",
+				     "SHA1 should be at least 12 digits long.\n" . $hereprev);
+			}
+		}
+
 # ignore non-hunk lines and lines being removed
 		next if (!$hunk_line || $line =~ /^-/);


--
Best wishes,
Wen Yang



```