[PATCH] ip6erspan: remove the incorrect mtu limit for ip6erspan

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE2547d

3 messages, 3 authors, 2019-10-09 · open the first message on its own page

[PATCH] ip6erspan: remove the incorrect mtu limit for ip6erspan

From: Haishuang Yan <hidden>
Date: 2019-10-08 09:56:47

ip6erspan driver calls ether_setup(), after commit 61e84623ace3
("net: centralize net_device min/max MTU checking"), the range
of mtu is [min_mtu, max_mtu], which is [68, 1500] by default.

It causes the dev mtu of the erspan device to not be greater
than 1500, this limit value is not correct for ip6erspan tap
device.

Signed-off-by: Haishuang Yan <redacted>
---
 net/ipv6/ip6_gre.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index d5779d6..787d9f2 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -2192,6 +2192,7 @@ static void ip6erspan_tap_setup(struct net_device *dev)
 {
 	ether_setup(dev);
 
+	dev->max_mtu = 0;
 	dev->netdev_ops = &ip6erspan_netdev_ops;
 	dev->needs_free_netdev = true;
 	dev->priv_destructor = ip6gre_dev_free;
-- 
1.8.3.1


Re: [PATCH] ip6erspan: remove the incorrect mtu limit for ip6erspan

From: William Tu <hidden>
Date: 2019-10-08 16:14:10

On Tue, Oct 08, 2019 at 05:56:03PM +0800, Haishuang Yan wrote:
ip6erspan driver calls ether_setup(), after commit 61e84623ace3
("net: centralize net_device min/max MTU checking"), the range
of mtu is [min_mtu, max_mtu], which is [68, 1500] by default.

It causes the dev mtu of the erspan device to not be greater
than 1500, this limit value is not correct for ip6erspan tap
device.

Signed-off-by: Haishuang Yan <redacted>
Thanks for the patch.

Acked-by: William Tu <redacted>
quoted hunk
---
 net/ipv6/ip6_gre.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index d5779d6..787d9f2 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -2192,6 +2192,7 @@ static void ip6erspan_tap_setup(struct net_device *dev)
 {
 	ether_setup(dev);
 
+	dev->max_mtu = 0;
 	dev->netdev_ops = &ip6erspan_netdev_ops;
 	dev->needs_free_netdev = true;
 	dev->priv_destructor = ip6gre_dev_free;
-- 
1.8.3.1

Re: [PATCH] ip6erspan: remove the incorrect mtu limit for ip6erspan

From: Jakub Kicinski <hidden>
Date: 2019-10-09 02:53:37

On Tue,  8 Oct 2019 17:56:03 +0800, Haishuang Yan wrote:
ip6erspan driver calls ether_setup(), after commit 61e84623ace3
("net: centralize net_device min/max MTU checking"), the range
of mtu is [min_mtu, max_mtu], which is [68, 1500] by default.

It causes the dev mtu of the erspan device to not be greater
than 1500, this limit value is not correct for ip6erspan tap
device.

Signed-off-by: Haishuang Yan <redacted>
Applied, but next time please make sure you add a Fixes tag, 
and put [PATCH net] in the subject for bug fixes. Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help