# Re: \[PATCH net\] hso: fix NULL-deref on tty open

- From: David Miller \<davem@davemloft.net\>
- Date: 2019-10-02 01:08:19 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/10/5731485
- Thread: https://ratatoskr.run/linux-usb/2019/09/5729691/t.md

```text
From: Johan Hovold <johan@kernel.org>
Date: Mon, 30 Sep 2019 17:12:41 +0200

> Fix NULL-pointer dereference on tty open due to a failure to handle a
> missing interrupt-in endpoint when probing modem ports:
> 
> 	BUG: kernel NULL pointer dereference, address: 0000000000000006
> 	...
> 	RIP: 0010:tiocmget_submit_urb+0x1c/0xe0 [hso]
> 	...
> 	Call Trace:
> 	hso_start_serial_device+0xdc/0x140 [hso]
> 	hso_serial_open+0x118/0x1b0 [hso]
> 	tty_open+0xf1/0x490
> 
> Fixes: 542f54823614 ("tty: Modem functions for the HSO driver")
> Signed-off-by: Johan Hovold <johan@kernel.org>

Applied, thanks.
```