[PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

Subsystems: realtek wireless driver (rtlwifi family), the rest

STALE2553d

4 messages, 3 authors, 2019-10-01 · open the first message on its own page

[PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

From: Austin Kim <hidden>
Date: 2019-09-17 06:50:54

'rtstatus' local variable is not used,
so remove it for clean-up.

Signed-off-by: Austin Kim <redacted>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
index 54a3aec..22441dd 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
@@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
 					    enum radio_path rfpath)
 {
 	int i;
-	bool rtstatus = true;
 	u32 *radioa_array_table;
 	u16 radioa_arraylen;
 
 	radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
 	radioa_array_table = RTL8723E_RADIOA_1TARRAY;
 
-	rtstatus = true;
-
 	switch (rfpath) {
 	case RF90_PATH_A:
 		for (i = 0; i < radioa_arraylen; i = i + 2) {
-- 
2.6.2

Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

From: Austin Kim <hidden>
Date: 2019-09-23 13:34:52

Hello, Maintainers...
Would you please review above patch if you are available?

Thanks,
Austin Kim

2019년 9월 17일 (화) 오후 3:50, Austin Kim [off-list ref]님이 작성:
quoted hunk
'rtstatus' local variable is not used,
so remove it for clean-up.

Signed-off-by: Austin Kim <redacted>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
index 54a3aec..22441dd 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
@@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
                                            enum radio_path rfpath)
 {
        int i;
-       bool rtstatus = true;
        u32 *radioa_array_table;
        u16 radioa_arraylen;

        radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
        radioa_array_table = RTL8723E_RADIOA_1TARRAY;

-       rtstatus = true;
-
        switch (rfpath) {
        case RF90_PATH_A:
                for (i = 0; i < radioa_arraylen; i = i + 2) {
--
2.6.2

RE: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

From: Pkshih <pkshih@realtek.com>
Date: 2019-09-24 01:22:12

-----Original Message-----
From: Austin Kim [mailto:austindh.kim@gmail.com]
Sent: Monday, September 23, 2019 9:35 PM
To: Pkshih; kvalo@codeaurora.org; davem@davemloft.net
Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

Hello, Maintainers...
Would you please review above patch if you are available?
You can check status of your patch here
https://patchwork.kernel.org/project/linux-wireless/list/?series=174859
If your patch is existing in patchwork, maintainer doesn't forget it.

Another thing is to avoid top posting that makes maintainer hard to read mail.

---
PK

Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

From: Kalle Valo <hidden>
Date: 2019-10-01 09:20:22

Austin Kim [off-list ref] wrote:
'rtstatus' local variable is not used,
so remove it for clean-up.

Signed-off-by: Austin Kim <redacted>
Patch applied to wireless-drivers-next.git, thanks.

6e7d59776311 rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

-- 
https://patchwork.kernel.org/patch/11148141/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help