[PATCH] brcmsmac: remove a useless test

Subsystems: broadcom brcm80211 ieee802.11 wireless drivers, the rest

STALE2545d

3 messages, 3 authors, 2019-10-01 · open the first message on its own page

[PATCH] brcmsmac: remove a useless test

From: Christophe JAILLET <hidden>
Date: 2019-09-15 19:32:21

'pih' is known to be non-NULL at this point, so the test can be removed.

Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
index 080e829da9b3..6bb34a12a94b 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
@@ -1816,8 +1816,7 @@ void brcms_b_phy_reset(struct brcms_hardware *wlc_hw)
 	udelay(2);
 	brcms_b_core_phy_clk(wlc_hw, ON);
 
-	if (pih)
-		wlc_phy_anacore(pih, ON);
+	wlc_phy_anacore(pih, ON);
 }
 
 /* switch to and initialize new band */
-- 
2.20.1

Re: [PATCH] brcmsmac: remove a useless test

From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Date: 2019-09-16 08:32:33

On 9/15/2019 9:32 PM, Christophe JAILLET wrote:
'pih' is known to be non-NULL at this point, so the test can be removed.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Christophe JAILLET <redacted>
---
  drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH] brcmsmac: remove a useless test

From: Kalle Valo <hidden>
Date: 2019-10-01 09:13:53

Christophe JAILLET [off-list ref] wrote:
'pih' is known to be non-NULL at this point, so the test can be removed.

Signed-off-by: Christophe JAILLET <redacted>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers-next.git, thanks.

3f1b32bdbb0a brcmsmac: remove a useless test

-- 
https://patchwork.kernel.org/patch/11146089/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help