# Re: \[PATCH\]\[next\] net/mlx5: fix missing assignment of variable err

- From: Saeed Mahameed \<hidden\>
- Date: 2019-09-04 23:30:53 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/09/5709613
- Thread: https://ratatoskr.run/linux-rdma/2019/09/5709485/t.md

```text
On Wed, 2019-09-04 at 20:29 +0100, Colin King wrote:
> From: Colin Ian King <redacted>
> 
> The error return from a call to mlx5_flow_namespace_set_peer is not
> being assigned to variable err and hence the error check following
> the call is currently not working.  Fix this by assigning ret as
> intended.
> 
> Addresses-Coverity: ("Logically dead code")
> Fixes: 8463daf17e80 ("net/mlx5: Add support to use SMFS in switchdev
> mode")
> Signed-off-by: Colin Ian King <redacted>
> ---

Applied to net-next-mlx5.

I have a cleanup series coming up, will send it all together to 
net-next soon. 

Thanks,
Saeed.
```