[PATCH] net: use unlikely for dql_avail case

Subsystems: networking drivers, networking [general], the rest

STALE2544d

2 messages, 2 authors, 2019-08-24 · open the first message on its own page

[PATCH] net: use unlikely for dql_avail case

From: xiaolinkui <hidden>
Date: 2019-08-22 06:59:12

This is an unlikely case, use unlikely() on it seems logical.

Signed-off-by: xiaolinkui <redacted>
---
 include/linux/netdevice.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 88292953aa6f..005f3da1b13d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3270,7 +3270,7 @@ static inline void netdev_tx_completed_queue(struct netdev_queue *dev_queue,
 	 */
 	smp_mb();
 
-	if (dql_avail(&dev_queue->dql) < 0)
+	if (unlikely(dql_avail(&dev_queue->dql) < 0))
 		return;
 
 	if (test_and_clear_bit(__QUEUE_STATE_STACK_XOFF, &dev_queue->state))
-- 
2.17.1


Re: [PATCH] net: use unlikely for dql_avail case

From: David Miller <davem@davemloft.net>
Date: 2019-08-24 21:23:50

From: xiaolinkui <redacted>
Date: Thu, 22 Aug 2019 14:58:16 +0800
This is an unlikely case, use unlikely() on it seems logical.

Signed-off-by: xiaolinkui <redacted>
Applied to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help