[PATCH net-next] cirrus: cs89x0: use devm_platform_ioremap_resource() to simplify code

Subsystems: networking drivers, the rest

STALE2576d

2 messages, 2 authors, 2019-08-21 · open the first message on its own page

[PATCH net-next] cirrus: cs89x0: use devm_platform_ioremap_resource() to simplify code

From: YueHaibing <hidden>
Date: 2019-08-21 13:03:13

Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.

Reported-by: Hulk Robot <redacted>
Signed-off-by: YueHaibing <redacted>
---
 drivers/net/ethernet/cirrus/cs89x0.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c
index b3e7faf..2d30972 100644
--- a/drivers/net/ethernet/cirrus/cs89x0.c
+++ b/drivers/net/ethernet/cirrus/cs89x0.c
@@ -1845,7 +1845,6 @@ static int __init cs89x0_platform_probe(struct platform_device *pdev)
 {
 	struct net_device *dev = alloc_etherdev(sizeof(struct net_local));
 	struct net_local *lp;
-	struct resource *mem_res;
 	void __iomem *virt_addr;
 	int err;
 
@@ -1861,8 +1860,7 @@ static int __init cs89x0_platform_probe(struct platform_device *pdev)
 		goto free;
 	}
 
-	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	virt_addr = devm_ioremap_resource(&pdev->dev, mem_res);
+	virt_addr = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(virt_addr)) {
 		err = PTR_ERR(virt_addr);
 		goto free;
-- 
2.7.4

Re: [PATCH net-next] cirrus: cs89x0: use devm_platform_ioremap_resource() to simplify code

From: David Miller <davem@davemloft.net>
Date: 2019-08-21 20:43:11

From: YueHaibing <redacted>
Date: Wed, 21 Aug 2019 21:02:41 +0800
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.

Reported-by: Hulk Robot <redacted>
Signed-off-by: YueHaibing <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help