# Re: \[PATCH net-next\] net: phy: modify assignment to OR for dev\_flags in phy\_attach\_direct

- From: Florian Fainelli \<f.fainelli@gmail.com\>
- Date: 2019-08-13 19:54:46 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/08/5686598
- Thread: https://ratatoskr.run/netdev/2019/08/5686598/t.md

```text
On 8/5/19 11:55 AM, Tao Ren wrote:
> Modify the assignment to OR when dealing with phydev->dev_flags in
> phy_attach_direct function, and this is to make sure dev_flags set in
> driver's probe callback won't be lost.

As Andrew pointed out already, this probably needs to be reworked, but
for now this looks reasonable:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian
```