# Re: \[PATCH net\] mvpp2: fix panic on module removal

- From: David Miller \<davem@davemloft.net\>
- Date: 2019-08-05 20:54:21 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/08/5678819
- Thread: https://ratatoskr.run/netdev/2019/07/5674047/t.md

```text
From: Matteo Croce <redacted>
Date: Mon, 5 Aug 2019 20:17:39 +0200

> On Mon, Aug 5, 2019 at 7:58 PM David Miller [ref] wrote:
>>
>> From: Matteo Croce <redacted>
>> Date: Wed, 31 Jul 2019 20:31:16 +0200
>>
>> > mvpp2 uses a delayed workqueue to gather traffic statistics.
>> > On module removal the workqueue can be destroyed before calling
>> > cancel_delayed_work_sync() on its works.
>> > Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().
>>
>> Please post a new version with the flush_workqueue() removed.
> 
> Hi,
> 
> I thought that it was already merged:
> 
> https://lore.kernel.org/netdev/20190801121330.30823-1-mcroce@redhat.com/
> 
> Let me know if it's ok already.

Oops, my bad. :-)

```