# Re: \[PATCH net\] net: dsa: mv88e6xxx: drop adjust\_link to enabled phylink

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2019-08-04 15:04:19 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/08/5677449
- Thread: https://ratatoskr.run/netdev/2019/07/5673796/t.md

```text
On Wed, Jul 31, 2019 at 05:42:39PM +0200, Hubert Feurstein wrote:
> We have to drop the adjust_link callback in order to finally migrate to
> phylink.
> 
> Otherwise we get the following warning during startup:
>   "mv88e6xxx 2188000.ethernet-1:10: Using legacy PHYLIB callbacks. Please
>    migrate to PHYLINK!"
> 
> The warning is generated in the function dsa_port_link_register_of in
> dsa/port.c:
> 
>   int dsa_port_link_register_of(struct dsa_port *dp)
>   {
>   	struct dsa_switch *ds = dp->ds;
> 
>   	if (!ds->ops->adjust_link)
>   		return dsa_port_phylink_register(dp);
> 
>   	dev_warn(ds->dev,
>   		 "Using legacy PHYLIB callbacks. Please migrate to PHYLINK!\n");
>   	[...]
>   }
> 
> Signed-off-by: Hubert Feurstein <redacted>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```