# Re: \[PATCH net v2\] mvpp2: fix panic on module removal

- From: David Miller \<davem@davemloft.net\>
- Date: 2019-08-01 17:08:51 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/08/5675131
- Thread: https://ratatoskr.run/netdev/2019/08/5674811/t.md

```text
From: Matteo Croce <redacted>
Date: Thu,  1 Aug 2019 14:13:30 +0200

> mvpp2 uses a delayed workqueue to gather traffic statistics.
> On module removal the workqueue can be destroyed before calling
> cancel_delayed_work_sync() on its works.
> Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().
> Also remove an unneeded call to flush_workqueue()
 ...
> Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Signed-off-by: Matteo Croce <redacted>

Applied and queued up for -stable, thanks.
```