# Re: \[PATCH V3 04/15\] ARM: exynos: cleanup cppcheck shifting error

- From: Krzysztof Kozlowski \<krzk@kernel.org\>
- Date: 2019-06-25 18:50:00 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/06/5639802
- Thread: https://ratatoskr.run/bpf/2019/06/5637122/t.md

```text
On Tue, Jun 25, 2019 at 11:03:45AM +0700, Phong Tran wrote:
> There is error from cppcheck tool
> "Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
> change to use BIT() marco for improvement.
> 
> Signed-off-by: Phong Tran <redacted>
> ---
>  arch/arm/mach-exynos/suspend.c | 2 +-

Thanks, applied with slightly different commit message. As Peter
pointed, there is no error because of GCC.  Usually we expect a reply to
comments on LKML...  and also you could take his hints and use them to
improve the commit msg to properly describe what is the problem.

Best regards,
Krzysztof

```
