# Re: \[PATCH 04/15\] ARM: exynos: cleanup cppcheck shifting error

- From: Krzysztof Kozlowski \<krzk@kernel.org\>
- Date: 2019-06-23 19:13:01 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/06/5637203
- Thread: https://ratatoskr.run/netdev/2019/06/5637122/t.md

```text
On Sun, 23 Jun 2019 at 17:14, Phong Tran [ref] wrote:
>
> [arch/arm/mach-exynos/suspend.c:288]: (error) Shifting signed 32-bit
> value by 31 bits is undefined behaviour
>
> Signed-off-by: Phong Tran <redacted>
> ---
>  arch/arm/mach-exynos/suspend.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Let's switch to BIT macro. It will solve the problem and is preferred
way of coding.

Best regards,
Krzysztof
```
