# Re: \[PATCH 10/15\] ARM: orion5x: cleanup cppcheck shifting errors

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2019-06-23 15:24:24 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/06/5637140
- Thread: https://ratatoskr.run/netdev/2019/06/5637122/t.md

```text
On Sun, Jun 23, 2019 at 10:13:08PM +0700, Phong Tran wrote:
> [arch/arm/mach-orion5x/pci.c:281]: (error) Shifting signed 32-bit value
> by 31 bits is undefined behaviour
> [arch/arm/mach-orion5x/pci.c:305]: (error) Shifting signed 32-bit value
> by 31 bits is undefined behaviour
> 
> Signed-off-by: Phong Tran <redacted>

Maybe using the BIT() macro would be better, but this is O.K.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```
