# Re: \[PATCH\] lib: objagg: Use struct\_size() in kzalloc()

- From: David Miller \<davem@davemloft.net\>
- Date: 2019-06-06 02:03:57 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/06/5619307
- Thread: https://ratatoskr.run/netdev/2019/06/5618851/t.md

```text
From: "Gustavo A. R. Silva" <redacted>
Date: Wed, 5 Jun 2019 09:45:16 -0500

> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
> 
> struct objagg_stats {
> 	...
>         struct objagg_obj_stats_info stats_info[];
> };
> 
> size = sizeof(*objagg_stats) + sizeof(objagg_stats->stats_info[0]) * count;
> instance = kzalloc(size, GFP_KERNEL);
> 
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
> 
> instance = kzalloc(struct_size(instance, stats_info, count), GFP_KERNEL);
> 
> Notice that, in this case, variable alloc_size is not necessary, hence it
> is removed.
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <redacted>

Applied.
```
