# \[PATCH net 1/2\] macsec: fix use-after-free of skb during RX

- From: Andreas Steinmetz \<hidden\>
- Date: 2019-06-30 20:48:33 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/06/11140827
- Thread: https://ratatoskr.run/netdev/2019/06/11140827/t.md

```text
Fix use-after-free of skb when rx_handler returns RX_HANDLER_PASS.

Signed-off-by: Andreas Steinmetz <redacted>

--- a/drivers/net/macsec.c	2019-06-05 20:23:27.640154747 +0200
+++ b/drivers/net/macsec.c	2019-06-05 20:23:46.791565816 +0200
@@ -1103,10 +1103,9 @@ static rx_handler_result_t macsec_handle
 	}
 
 	skb = skb_unshare(skb, GFP_ATOMIC);
-	if (!skb) {
-		*pskb = NULL;
+	*pskb = skb;
+	if (!skb)
 		return RX_HANDLER_CONSUMED;
-	}
 
 	pulled_sci = pskb_may_pull(skb, macsec_extra_len(true));
 	if (!pulled_sci) {

```