[PATCH] sdio: Fix a memory leaking bug in wl1271_probe()
From: Gen Zhang <hidden>
Date: 2019-05-23 13:54:00
Also in:
lkml
Subsystem:
the rest, ti wilink wireless drivers · Maintainer:
Linus Torvalds
In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(), when this allocation fails, ENOMEM is returned. However, 'pdev_data' and 'glue' are allocated by devm_kzalloc() before 'glue->core'. When platform_device_alloc() returns NULL, we should also free 'pdev_data' and 'glue' before wl1271_probe() ends to prevent leaking memory. Signed-off-by: Gen Zhang <redacted> ---
diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index 4d4b0770..e134f30 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c@@ -340,7 +340,7 @@ static int wl1271_probe(struct sdio_func *func, if (!glue->core) { dev_err(glue->dev, "can't allocate platform_device"); ret = -ENOMEM; - goto out; + goto out_free; } glue->core->dev.parent = &func->dev;
@@ -385,6 +385,10 @@ static int wl1271_probe(struct sdio_func *func, out_dev_put: platform_device_put(glue->core); +out_free: + devm_kfree(&func->dev, pdev_data); + devm_kfree(&func->dev, glue); + out: return ret; }
---