[PATCH] net: mvpp2: setup link irqs for ports with in-band-status phylink
From: Yanko Kaneti <hidden>
Date: 2019-05-28 20:03:03
Subsystem:
marvell mvpp2 ethernet driver, networking drivers, the rest · Maintainers:
Marcin Wojtas, Russell King, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Hello This might be misguided but it seems to fix link status on my mcbin- singleshot SFP+ ports -Yanko -- >8 -- MACCHIATObin Single-shot uses the direct-to-MAC SFP+ ports setup which phylink supports in in-band-status mode. Don't assume phylink means external phy and connect the link irqs. Signed-off-by: Yanko Kaneti <redacted> --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index d38952eb7aa9..2f6acc38087c 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c@@ -3447,7 +3447,7 @@ static int mvpp2_open(struct net_device *dev) valid = true; } - if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) { + if (priv->hw_version == MVPP22 && port->link_irq && !port->has_phy) { err = request_irq(port->link_irq, mvpp2_link_status_isr, 0, dev->name, port); if (err) {
--