[PATCH] virtio_net: remove hcpu from virtnet_clean_affinity

Subsystems: networking drivers, the rest, virtio net driver

STALE2699d

2 messages, 2 authors, 2019-03-19 · open the first message on its own page

[PATCH] virtio_net: remove hcpu from virtnet_clean_affinity

From: Peter Xu <peterx@redhat.com>
Date: 2019-03-18 06:56:16

The variable is never used.

CC: Michael S. Tsirkin <mst@redhat.com>
CC: Jason Wang <redacted>
CC: virtualization@lists.linux-foundation.org
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 drivers/net/virtio_net.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 7eb38ea9ba56..1b03c4b6ebff 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1925,7 +1925,7 @@ static int virtnet_vlan_rx_kill_vid(struct net_device *dev,
 	return 0;
 }
 
-static void virtnet_clean_affinity(struct virtnet_info *vi, long hcpu)
+static void virtnet_clean_affinity(struct virtnet_info *vi)
 {
 	int i;
 
@@ -1949,7 +1949,7 @@ static void virtnet_set_affinity(struct virtnet_info *vi)
 	int stride;
 
 	if (!zalloc_cpumask_var(&mask, GFP_KERNEL)) {
-		virtnet_clean_affinity(vi, -1);
+		virtnet_clean_affinity(vi);
 		return;
 	}
 
@@ -1999,7 +1999,7 @@ static int virtnet_cpu_down_prep(unsigned int cpu, struct hlist_node *node)
 	struct virtnet_info *vi = hlist_entry_safe(node, struct virtnet_info,
 						   node);
 
-	virtnet_clean_affinity(vi, cpu);
+	virtnet_clean_affinity(vi);
 	return 0;
 }
 
@@ -2735,7 +2735,7 @@ static void virtnet_del_vqs(struct virtnet_info *vi)
 {
 	struct virtio_device *vdev = vi->vdev;
 
-	virtnet_clean_affinity(vi, -1);
+	virtnet_clean_affinity(vi);
 
 	vdev->config->del_vqs(vdev);
 
-- 
2.17.1

Re: [PATCH] virtio_net: remove hcpu from virtnet_clean_affinity

From: David Miller <davem@davemloft.net>
Date: 2019-03-19 05:26:58

From: Peter Xu <peterx@redhat.com>
Date: Mon, 18 Mar 2019 14:56:06 +0800
The variable is never used.

CC: Michael S. Tsirkin <mst@redhat.com>
CC: Jason Wang <redacted>
CC: virtualization@lists.linux-foundation.org
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Peter Xu <peterx@redhat.com>
This looks rather uncontroversial and straightforward so I've applied
this to net-next.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help