Thread (6 messages) 6 messages, 2 authors, 2019-02-28
STALE2658d
Revisions (2)
  1. v1 current
  2. v2 [diff vs current]

[PATCH net-next 3/3] net: phy: marvell10g: set the PHY in low power by default

From: Antoine Tenart <hidden>
Date: 2019-02-28 13:50:22
Also in: lkml
Subsystem: ethernet phy library, marvell mv88x3310 phy driver, networking drivers, the rest · Maintainers: Andrew Lunn, Heiner Kallweit, Russell King, Marek Behún, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

When the Marvell 10G PHYs are set out of reset, the LPOWER bit is set
depending on an hardware configuration choice. We also do not know what
is the PHY state at boot time. Hence, set the PHY in low power by
default when this driver probes.

Signed-off-by: Antoine Tenart <redacted>
---
 drivers/net/phy/marvell10g.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
index e5d098bd33a6..765edd34a7dd 100644
--- a/drivers/net/phy/marvell10g.c
+++ b/drivers/net/phy/marvell10g.c
@@ -245,17 +245,8 @@ static int mv3310_probe(struct phy_device *phydev)
 	if (ret)
 		return ret;
 
-	return 0;
-}
-
-static int mv3310_suspend(struct phy_device *phydev)
-{
-	return 0;
-}
-
-static int mv3310_resume(struct phy_device *phydev)
-{
-	return mv3310_hwmon_config(phydev, true);
+	/* Set the PHY in low power mode by default */
+	return mv3310_suspend(phydev);
 }
 
 /* Some PHYs in the Alaska family such as the 88X3310 and the 88E2010
-- 
2.20.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help