# Re: \[PATCH 01/18\] MIPS: lantiq: pass struct device to DMA API functions

- From: Paul Burton \<hidden\>
- Date: 2019-02-12 17:41:35 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/02/5511799
- Thread: https://ratatoskr.run/linux-mips/2019/02/5501082/t.md

```text
Hello,

Christoph Hellwig wrote:
> The DMA API generally relies on a struct device to work properly, and
> only barely works without one for legacy reasons.  Pass the easily
> available struct device from the platform_device to remedy this.
> 
> Also use GFP_KERNEL instead of GFP_ATOMIC as the gfp_t for the memory
> allocation, as we aren't in interrupt context or under a lock.
> 
> Note that this whole function looks somewhat bogus given that we never
> even look at the returned dma address, and the CPHYSADDR magic on
> a returned noncached mapping looks "interesting".  But I'll leave
> that to people more familiar with the code to sort out.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]
```