# Re: \[PATCH 3/3 net-next\] test\_objagg: Uninitialized variable in error handling

- From: David Miller \<davem@davemloft.net\>
- Date: 2019-02-14 06:13:51 
- List: netdev
- Page: https://ratatoskr.run/netdev/2019/02/11125928
- Thread: https://ratatoskr.run/netdev/2019/02/11125746/t.md

```text
From: Dan Carpenter <redacted>
Date: Wed, 13 Feb 2019 11:59:31 +0300

> We need to set the error message on this path otherwise some of the
> callers, such as test_hints_case(), print from an uninitialized pointer.
> 
> We had a similar bug earlier and set "errmsg" to NULL in the caller,
> test_delta_action_item().  That code is no longer required so I have
> removed it.
> 
> Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation")
> Signed-off-by: Dan Carpenter <redacted>

Applied.
```
