[PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

Subsystems: networking drivers, the rest

STALE2829d

3 messages, 3 authors, 2019-01-25 · open the first message on its own page

[PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

From: Maciej Żenczykowski <hidden>
Date: 2019-01-24 11:07:16

From: Maciej Żenczykowski <redacted>

__bpf_redirect() and act_mirred checks this boolean
to determine whether to prefix an ethernet header.

Signed-off-by: Maciej Żenczykowski <redacted>
---
 include/linux/if_arp.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/linux/if_arp.h b/include/linux/if_arp.h
index 6756fea18b69..e44746de95cd 100644
--- a/include/linux/if_arp.h
+++ b/include/linux/if_arp.h
@@ -54,6 +54,7 @@ static inline bool dev_is_mac_header_xmit(const struct net_device *dev)
 	case ARPHRD_IPGRE:
 	case ARPHRD_VOID:
 	case ARPHRD_NONE:
+	case ARPHRD_RAWIP:
 		return false;
 	default:
 		return true;
-- 
2.20.1.321.g9e740568ce-goog

Re: [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2019-01-24 11:27:17

On 01/24/2019 12:07 PM, Maciej Żenczykowski wrote:
From: Maciej Żenczykowski <redacted>

__bpf_redirect() and act_mirred checks this boolean
to determine whether to prefix an ethernet header.

Signed-off-by: Maciej Żenczykowski <redacted>
I presume David would pick this up for net tree, so:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Re: [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

From: David Miller <davem@davemloft.net>
Date: 2019-01-25 06:45:59

From: Maciej Żenczykowski <redacted>
Date: Thu, 24 Jan 2019 03:07:02 -0800
From: Maciej Żenczykowski <redacted>

__bpf_redirect() and act_mirred checks this boolean
to determine whether to prefix an ethernet header.

Signed-off-by: Maciej Żenczykowski <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help