[PATCH] sb1000: fix a couple of indentation issues

Subsystems: networking drivers, the rest

STALE2835d

3 messages, 3 authors, 2019-01-18 · open the first message on its own page

[PATCH] sb1000: fix a couple of indentation issues

From: Colin King <hidden>
Date: 2019-01-17 00:13:06

From: Colin Ian King <redacted>

There is an if statement and a return statement that are incorrectly
indented. Fix these.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/sb1000.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
index 7820fced33f6..af4838124f8c 100644
--- a/drivers/net/sb1000.c
+++ b/drivers/net/sb1000.c
@@ -540,12 +540,12 @@ sb1000_activate(const int ioaddr[], const char* name)
 	if ((status = card_send_command(ioaddr, name, Command1, st)))
 		return status;
 	if (st[3] != 0xf1) {
-    	if ((status = sb1000_start_get_set_command(ioaddr, name)))
+		if ((status = sb1000_start_get_set_command(ioaddr, name)))
 			return status;
 		return -EIO;
 	}
 	udelay(1000);
-    return sb1000_start_get_set_command(ioaddr, name);
+	return sb1000_start_get_set_command(ioaddr, name);
 }
 
 /* get SB1000 firmware version */
-- 
2.19.1

Re: [PATCH] sb1000: fix a couple of indentation issues

From: Joe Perches <joe@perches.com>
Date: 2019-01-17 00:21:06

On Thu, 2019-01-17 at 00:13 +0000, Colin King wrote:
From: Colin Ian King <redacted>

There is an if statement and a return statement that are incorrectly
indented. Fix these.
[]
quoted hunk
diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
[]
quoted hunk
@@ -540,12 +540,12 @@ sb1000_activate(const int ioaddr[], const char* name)
 	if ((status = card_send_command(ioaddr, name, Command1, st)))
 		return status;
 	if (st[3] != 0xf1) {
-    	if ((status = sb1000_start_get_set_command(ioaddr, name)))
+		if ((status = sb1000_start_get_set_command(ioaddr, name)))
Probably better to remove the assignment in the if at the same time.

		status = sb1000_start_get_set_command(ioaddr, name);
		if (status)
quoted hunk
 			return status;
 		return -EIO;
 	}
 	udelay(1000);
-    return sb1000_start_get_set_command(ioaddr, name);
+	return sb1000_start_get_set_command(ioaddr, name);
 }
 
 /* get SB1000 firmware version */

Re: [PATCH] sb1000: fix a couple of indentation issues

From: David Miller <davem@davemloft.net>
Date: 2019-01-18 05:52:09

From: Colin King <redacted>
Date: Thu, 17 Jan 2019 00:13:01 +0000
From: Colin Ian King <redacted>

There is an if statement and a return statement that are incorrectly
indented. Fix these.

Signed-off-by: Colin Ian King <redacted>
Applied to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help