From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2019-01-16 09:57:51
Hi,
This serries collects some little modifications to DT bindings and associated
drivers changes for supporting the upcoming SAM9X60 SoC.
I took the advantage of this series for fixing some of the leftovers in DT
bindings for reset controller and Ethernet macb.
These changes touch several sub-systems but I would like that these (mostly
trivial) patches stay together for facilitating reviews, prevent breaking
dependencies and facilitating the tracking of acceptance status. However, tell
me if you think otherwise.
My intentions are that the series would enter Mainline through arm-soc tree:
sounds okay to everyone? If okay, I'm ready to collect Ack tags...
For the first batch, I send the whole series to everyone. I'll try my best to
reduce subsequent message deliveries if one part of the serries needs rework.
Best regards,
Nicolas
Nicolas Ferre (8):
dt-bindings: arm: atmel: add missing samx7 to reset controller
dt-bindings: arm: atmel: add new sam9x60 reset controller binding
dt-bindings: arm: atmel: add new sam9x60 SFR binding
net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100
interface
net/macb: bindings doc: add sam9x60 binding
power: reset: at91-reset: add support for sam9x60 SoC
USB: host: ohci-at91: add sam9x60-sfr definition for ohci
net: macb: add sam9x60-macb compatibility string
.../devicetree/bindings/arm/atmel-sysregs.txt | 4 +++-
Documentation/devicetree/bindings/net/macb.txt | 4 ++--
drivers/net/ethernet/cadence/macb_main.c | 1 +
drivers/power/reset/at91-reset.c | 13 +++++++++++++
drivers/usb/host/ohci-at91.c | 7 +++++--
5 files changed, 24 insertions(+), 5 deletions(-)
--
2.17.1
@@ -21,7 +21,7 @@ Its subnodes can be: RSTC Reset Controller required properties: - compatible: Should be "atmel,<chip>-rstc".- <chip> can be "at91sam9260" or "at91sam9g45" or "sama5d3"+ <chip> can be "at91sam9260", "at91sam9g45", "sama5d3" or "samx7" - reg: Should contain registers location and length - clocks: phandle to input clock.
@@ -22,6 +22,7 @@ Its subnodes can be: RSTC Reset Controller required properties: - compatible: Should be "atmel,<chip>-rstc". <chip> can be "at91sam9260", "at91sam9g45", "sama5d3" or "samx7"+ it also can be "microchip,sam9x60-rstc" - reg: Should contain registers location and length - clocks: phandle to input clock.
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2019-01-16 09:58:05
This removes a line left while adding the correct compatibility string for
sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Documentation/devicetree/bindings/net/macb.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
@@ -3,8 +3,7 @@ Required properties: - compatible: Should be "cdns,[<chip>-]{macb|gem}" Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC.- Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs or the 10/100Mbit IP- available on sama5d3 SoCs.+ Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs. Use "cdns,np4-macb" for NP4 SoC devices. Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb". Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2019-01-16 09:58:12
Add support for additional reset causes and the proper compatibility
string for sam9x60 SoC. The restart function is the same as the samx7.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/power/reset/at91-reset.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2019-01-16 09:58:16
Add this SFR compatible definition for the sam9x60 SoC and manage
its use in ohci-at91.c driver.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/usb/host/ohci-at91.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2019-01-16 09:58:28
Add a new compatibility string for this product. It's using
at91sam9260-macb layout but has a newer hardware revision: it's safer
to use its own string.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/net/ethernet/cadence/macb_main.c | 1 +
1 file changed, 1 insertion(+)
@@ -4,6 +4,7 @@ Required properties: - compatible: Should be "cdns,[<chip>-]{macb|gem}" Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC. Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs.+ Use "cdns,sam9x60-macb" for Microchip sam9x60 SoC. Use "cdns,np4-macb" for NP4 SoC devices. Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb". Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: 2019-01-16 09:58:56
Add this SFR compatible definition for the sam9x60 SoC. Will be needed
in OHCI driver: ohci-at91.c.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 +
1 file changed, 1 insertion(+)
@@ -148,6 +148,7 @@ required properties: - compatible: Should be "atmel,<chip>-sfr", "syscon" or "atmel,<chip>-sfrbu", "syscon" <chip> can be "sama5d3", "sama5d4" or "sama5d2".+ it also can be "microchip,sam9x60-sfr", "syscon". - reg: Should contain registers location and length sfr@f0038000 {
@@ -22,6 +22,7 @@ Its subnodes can be: RSTC Reset Controller required properties: - compatible: Should be "atmel,<chip>-rstc". <chip> can be "at91sam9260", "at91sam9g45", "sama5d3" or "samx7"+ it also can be "microchip,sam9x60-rstc"
How is this related to at91sam9260-rstc?
The 'x' is a wildcard? We generally avoid wildcards.
- reg: Should contain registers location and length
- clocks: phandle to input clock.
--
2.17.1
From: Rob Herring <robh@kernel.org> Date: 2019-01-22 01:10:18
On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote:
quoted hunk
This removes a line left while adding the correct compatibility string for
sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Documentation/devicetree/bindings/net/macb.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
@@ -3,8 +3,7 @@ Required properties: - compatible: Should be "cdns,[<chip>-]{macb|gem}" Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC.- Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs or the 10/100Mbit IP- available on sama5d3 SoCs.+ Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs.
Where is "atmel,sama5d3-macb"?
Use "cdns,np4-macb" for NP4 SoC devices.
Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb".
Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on
--
2.17.1
@@ -22,6 +22,7 @@ Its subnodes can be: RSTC Reset Controller required properties: - compatible: Should be "atmel,<chip>-rstc". <chip> can be "at91sam9260", "at91sam9g45", "sama5d3" or "samx7"+ it also can be "microchip,sam9x60-rstc"
How is this related to at91sam9260-rstc?
at91sam9260 and sam9x60 are completely different products (they share
the same core though...). I know the naming could be misleading but it
is like it is...
The 'x' is a wildcard? We generally avoid wildcards.
Here, the 'x' is definitively not a wildcard nor a kind of "family"
name, it's included in the (upcoming) single product's name.
I hope it clarifies.
Best regards,
Nicolas
quoted
- reg: Should contain registers location and length
- clocks: phandle to input clock.
--
2.17.1
Hi Rob,
On 22/01/2019 at 02:10, Rob Herring wrote:
On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote:
quoted
This removes a line left while adding the correct compatibility string for
sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Documentation/devicetree/bindings/net/macb.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
@@ -3,8 +3,7 @@ Required properties: - compatible: Should be "cdns,[<chip>-]{macb|gem}" Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC.- Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs or the 10/100Mbit IP- available on sama5d3 SoCs.+ Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs.
Where is "atmel,sama5d3-macb"?
It's actually a couple of line below: line 13 of the resulting macb.txt
file. It was already in the file when I removed the leftovers.
Do you advice to try to better sort entries in this file? Is there a
common pattern?
Best regards,
Nicolas
quoted
Use "cdns,np4-macb" for NP4 SoC devices.
Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb".
Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on
--
2.17.1
@@ -22,6 +22,7 @@ Its subnodes can be: RSTC Reset Controller required properties: - compatible: Should be "atmel,<chip>-rstc". <chip> can be "at91sam9260", "at91sam9g45", "sama5d3" or "samx7"+ it also can be "microchip,sam9x60-rstc"
How is this related to at91sam9260-rstc?
at91sam9260 and sam9x60 are completely different products (they share
the same core though...). I know the naming could be misleading but it
is like it is...
quoted
The 'x' is a wildcard? We generally avoid wildcards.
Here, the 'x' is definitively not a wildcard nor a kind of "family"
name, it's included in the (upcoming) single product's name.
I hope it clarifies.
Yes, thanks.
Reviewed-by: Rob Herring <robh@kernel.org>
From: Rob Herring <robh@kernel.org> Date: 2019-01-22 13:41:17
On Tue, Jan 22, 2019 at 3:09 AM [off-list ref] wrote:
Hi Rob,
On 22/01/2019 at 02:10, Rob Herring wrote:
quoted
On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote:
quoted
This removes a line left while adding the correct compatibility string for
sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Documentation/devicetree/bindings/net/macb.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
@@ -3,8 +3,7 @@ Required properties: - compatible: Should be "cdns,[<chip>-]{macb|gem}" Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC.- Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs or the 10/100Mbit IP- available on sama5d3 SoCs.+ Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs.
Where is "atmel,sama5d3-macb"?
It's actually a couple of line below: line 13 of the resulting macb.txt
file. It was already in the file when I removed the leftovers.
Do you advice to try to better sort entries in this file? Is there a
common pattern?
Okay, it's fine.
Reviewed-by: Rob Herring <robh@kernel.org>
From: Sebastian Reichel <sre@kernel.org> Date: 2019-01-24 09:58:31
Hi,
On Wed, Jan 16, 2019 at 10:57:42AM +0100, Nicolas Ferre wrote:
quoted hunk
Add support for additional reset causes and the proper compatibility
string for sam9x60 SoC. The restart function is the same as the samx7.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/power/reset/at91-reset.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
Hi Sebastian,
On 23/01/2019 at 19:34, Sebastian Reichel wrote:
Hi,
On Wed, Jan 16, 2019 at 10:57:42AM +0100, Nicolas Ferre wrote:
quoted
Add support for additional reset causes and the proper compatibility
string for sam9x60 SoC. The restart function is the same as the samx7.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/power/reset/at91-reset.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
From: Sebastian Reichel <sre@kernel.org> Date: 2019-01-24 17:12:06
Hi,
On Thu, Jan 24, 2019 at 10:34:50AM +0000, Nicolas.Ferre@microchip.com wrote:
Hi Sebastian,
On 23/01/2019 at 19:34, Sebastian Reichel wrote:
quoted
Hi,
On Wed, Jan 16, 2019 at 10:57:42AM +0100, Nicolas Ferre wrote:
quoted
Add support for additional reset causes and the proper compatibility
string for sam9x60 SoC. The restart function is the same as the samx7.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/power/reset/at91-reset.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
Patch looks fine to me. But I will wait a bit with merging, so that
Alexandre or Ludovic have a chance to provide feedback.
What about merging this patch with the whole series through the at91
then arm-soc trees?
It seems to be possible to merge this standalone, but merging
through at91/arm-soc is also fine with me.
Acked-by: Sebastian Reichel <redacted>
-- Sebastian
Hi David,
On 16/01/2019 at 10:57, Nicolas Ferre wrote:
Add a new compatibility string for this product. It's using
at91sam9260-macb layout but has a newer hardware revision: it's safer
to use its own string.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
I'm thinking of pushing this patch with the others of the series through
arm-soc tree. Can I have your "Acked-by" tag then?
Best regards,
Nicolas
Hi,
This series collects some little modifications to DT bindings and associated
drivers changes for supporting the upcoming SAM9X60 SoC.
I took the advantage of this series for fixing some of the leftovers in DT
bindings for reset controller and Ethernet macb.
These changes touch several sub-systems but I would like that these (mostly
trivial) patches stay together for facilitating reviews, prevent breaking
dependencies and facilitating the tracking of acceptance status. However, tell
me if you think otherwise.
It seems it's not the preferred way to go and that I must split and send
to sub-system Maintainers so that bindings and driver code go together
through Maintainer's git trees (USB, power/reset, netdev).
My intentions are that the series would enter Mainline through arm-soc tree:
sounds okay to everyone? If okay, I'm ready to collect Ack tags...
I'm re-sending this split series. Some of the "Reviewed-by:" are missing
so we'll have the chance to add them on individual series.
Thanks for your reviews so far.
Best regards,
Nicolas
For the first batch, I send the whole series to everyone. I'll try my best to
reduce subsequent message deliveries if one part of the serries needs rework.
Best regards,
Nicolas
Nicolas Ferre (8):
dt-bindings: arm: atmel: add missing samx7 to reset controller
dt-bindings: arm: atmel: add new sam9x60 reset controller binding
dt-bindings: arm: atmel: add new sam9x60 SFR binding
net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100
interface
net/macb: bindings doc: add sam9x60 binding
power: reset: at91-reset: add support for sam9x60 SoC
USB: host: ohci-at91: add sam9x60-sfr definition for ohci
net: macb: add sam9x60-macb compatibility string
.../devicetree/bindings/arm/atmel-sysregs.txt | 4 +++-
Documentation/devicetree/bindings/net/macb.txt | 4 ++--
drivers/net/ethernet/cadence/macb_main.c | 1 +
drivers/power/reset/at91-reset.c | 13 +++++++++++++
drivers/usb/host/ohci-at91.c | 7 +++++--
5 files changed, 24 insertions(+), 5 deletions(-)