[PATCH] net/core/neighbour: fix kmemleak minimal reference count for hash tables

Subsystems: networking [general], the rest

STALE2837d

2 messages, 2 authors, 2019-01-16 · open the first message on its own page

[PATCH] net/core/neighbour: fix kmemleak minimal reference count for hash tables

From: Konstantin Khlebnikov <hidden>
Date: 2019-01-14 10:38:52

This should be 1 for normal allocations, 0 disables leak reporting.

Signed-off-by: Konstantin Khlebnikov <redacted>
Reported-by: Cong Wang <redacted>
Fixes: 85704cb8dcfd ("net/core/neighbour: tell kmemleak about hash tables")
---
 net/core/neighbour.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 3e27a779f288..96fdc9134726 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -450,7 +450,7 @@ static struct neigh_hash_table *neigh_hash_alloc(unsigned int shift)
 		buckets = (struct neighbour __rcu **)
 			  __get_free_pages(GFP_ATOMIC | __GFP_ZERO,
 					   get_order(size));
-		kmemleak_alloc(buckets, size, 0, GFP_ATOMIC);
+		kmemleak_alloc(buckets, size, 1, GFP_ATOMIC);
 	}
 	if (!buckets) {
 		kfree(ret);

Re: [PATCH] net/core/neighbour: fix kmemleak minimal reference count for hash tables

From: David Miller <davem@davemloft.net>
Date: 2019-01-16 21:39:59

From: Konstantin Khlebnikov <redacted>
Date: Mon, 14 Jan 2019 13:38:43 +0300
This should be 1 for normal allocations, 0 disables leak reporting.

Signed-off-by: Konstantin Khlebnikov <redacted>
Reported-by: Cong Wang <redacted>
Fixes: 85704cb8dcfd ("net/core/neighbour: tell kmemleak about hash tables")
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help