[PATCH] bonding: convert to DEFINE_SHOW_ATTRIBUTE

Subsystems: bonding driver, networking drivers, the rest

STALE2842d

2 messages, 2 authors, 2018-12-10 · open the first message on its own page

[PATCH] bonding: convert to DEFINE_SHOW_ATTRIBUTE

From: Yangtao Li <tiny.windzz@gmail.com>
Date: 2018-12-10 16:08:51

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/net/bonding/bond_debugfs.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
index 3868e1a5126d..1360f1ffe070 100644
--- a/drivers/net/bonding/bond_debugfs.c
+++ b/drivers/net/bonding/bond_debugfs.c
@@ -45,19 +45,7 @@ static int bond_debug_rlb_hash_show(struct seq_file *m, void *v)
 
 	return 0;
 }
-
-static int bond_debug_rlb_hash_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, bond_debug_rlb_hash_show, inode->i_private);
-}
-
-static const struct file_operations bond_debug_rlb_hash_fops = {
-	.owner		= THIS_MODULE,
-	.open		= bond_debug_rlb_hash_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(bond_debug_rlb_hash);
 
 void bond_debug_register(struct bonding *bond)
 {
-- 
2.17.0

Re: [PATCH] bonding: convert to DEFINE_SHOW_ATTRIBUTE

From: David Miller <davem@davemloft.net>
Date: 2018-12-10 20:06:07

From: Yangtao Li <tiny.windzz@gmail.com>
Date: Mon, 10 Dec 2018 11:08:45 -0500
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help