[PATCH] wil6210: remove set but not used variable 'wdev'

Subsystems: atheros ath generic utilities, the rest, wilocity wil6210 wireless driver

STALE2838d

3 messages, 3 authors, 2018-12-20 · open the first message on its own page

[PATCH] wil6210: remove set but not used variable 'wdev'

From: YueHaibing <hidden>
Date: 2018-12-05 07:50:57

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/ath/wil6210/main.c: In function '_wil6210_disconnect':
drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
 variable 'wdev' set but not used [-Wunused-but-set-variable]

It never used since commit ("e1b43407c034 wil6210: refactor disconnect flow")

Signed-off-by: YueHaibing <redacted>
---
 drivers/net/wireless/ath/wil6210/main.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index ba6a2ee..5b7de00 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -404,7 +404,6 @@ static void _wil6210_disconnect(struct wil6210_vif *vif, const u8 *bssid,
 {
 	struct wil6210_priv *wil;
 	struct net_device *ndev;
-	struct wireless_dev *wdev;
 	int cid = -ENOENT;
 
 	if (unlikely(!vif))
@@ -412,7 +411,6 @@ static void _wil6210_disconnect(struct wil6210_vif *vif, const u8 *bssid,
 
 	wil = vif_to_wil(vif);
 	ndev = vif_to_ndev(vif);
-	wdev = vif_to_wdev(vif);
 
 	might_sleep();
 	wil_info(wil, "disconnect bssid=%pM, reason=%d\n", bssid, reason_code);

Re: [PATCH] wil6210: remove set but not used variable 'wdev'

From: <hidden>
Date: 2018-12-08 18:08:47

On 2018-12-05 09:59, YueHaibing wrote:
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/ath/wil6210/main.c: In function 
'_wil6210_disconnect':
drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
 variable 'wdev' set but not used [-Wunused-but-set-variable]

It never used since commit ("e1b43407c034 wil6210: refactor disconnect 
flow")

Signed-off-by: YueHaibing <redacted>
---
 drivers/net/wireless/ath/wil6210/main.c | 2 --
 1 file changed, 2 deletions(-)
Reviewed-by: Maya Erez <redacted>
-- 
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project

Re: [PATCH] wil6210: remove set but not used variable 'wdev'

From: Kalle Valo <hidden>
Date: 2018-12-20 07:45:07

YueHaibing [off-list ref] wrote:
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/ath/wil6210/main.c: In function '_wil6210_disconnect':
drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
 variable 'wdev' set but not used [-Wunused-but-set-variable]

It never used since commit ("e1b43407c034 wil6210: refactor disconnect flow")

Signed-off-by: YueHaibing <redacted>
Reviewed-by: Maya Erez <redacted>
Signed-off-by: Kalle Valo <redacted>
Patch applied to ath-next branch of ath.git, thanks.

3fe970e76b37 wil6210: remove set but not used variable 'wdev'

-- 
https://patchwork.kernel.org/patch/10713127/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help