[PATCH net] net: stmmac: Fix an error code in probe()

Subsystems: networking drivers, stmmac ethernet driver, the rest

STALE2835d

2 messages, 2 authors, 2018-12-18 · open the first message on its own page

[PATCH net] net: stmmac: Fix an error code in probe()

From: Dan Carpenter <hidden>
Date: 2018-12-17 08:06:34

The function should return an error if create_singlethread_workqueue()
fails.

Fixes: 34877a15f787 ("net: stmmac: Rework and fix TX Timeout code")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 5551fead8f66..c4a35e932f05 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4250,6 +4250,7 @@ int stmmac_dvr_probe(struct device *device,
 	priv->wq = create_singlethread_workqueue("stmmac_wq");
 	if (!priv->wq) {
 		dev_err(priv->device, "failed to create workqueue\n");
+		ret = -ENOMEM;
 		goto error_wq;
 	}
 
-- 
2.17.1

Re: [PATCH net] net: stmmac: Fix an error code in probe()

From: David Miller <davem@davemloft.net>
Date: 2018-12-18 23:50:31

From: Dan Carpenter <redacted>
Date: Mon, 17 Dec 2018 11:06:06 +0300
The function should return an error if create_singlethread_workqueue()
fails.

Fixes: 34877a15f787 ("net: stmmac: Rework and fix TX Timeout code")
Signed-off-by: Dan Carpenter <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help