[PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK

Subsystems: networking [general], the rest

STALE2824d

3 messages, 3 authors, 2018-12-14 · open the first message on its own page

[PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK

From: Jakub Kicinski <hidden>
Date: 2018-12-14 19:38:59

NETLINK_DUMP_STRICT_CHK can be used for all GET requests,
dumps as well as doit handlers.  Replace the DUMP in the
name with GET make that clearer.

Signed-off-by: Jakub Kicinski <redacted>
---
 include/uapi/linux/netlink.h       | 2 +-
 net/netlink/af_netlink.c           | 4 ++--
 tools/include/uapi/linux/netlink.h | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h
index 486ed1f0c0bc..0a4d73317759 100644
--- a/include/uapi/linux/netlink.h
+++ b/include/uapi/linux/netlink.h
@@ -155,7 +155,7 @@ enum nlmsgerr_attrs {
 #define NETLINK_LIST_MEMBERSHIPS	9
 #define NETLINK_CAP_ACK			10
 #define NETLINK_EXT_ACK			11
-#define NETLINK_DUMP_STRICT_CHK		12
+#define NETLINK_GET_STRICT_CHK		12
 
 struct nl_pktinfo {
 	__u32	group;
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 6bb9f3cde0b0..3c023d6120f6 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1706,7 +1706,7 @@ static int netlink_setsockopt(struct socket *sock, int level, int optname,
 			nlk->flags &= ~NETLINK_F_EXT_ACK;
 		err = 0;
 		break;
-	case NETLINK_DUMP_STRICT_CHK:
+	case NETLINK_GET_STRICT_CHK:
 		if (val)
 			nlk->flags |= NETLINK_F_STRICT_CHK;
 		else
@@ -1806,7 +1806,7 @@ static int netlink_getsockopt(struct socket *sock, int level, int optname,
 			return -EFAULT;
 		err = 0;
 		break;
-	case NETLINK_DUMP_STRICT_CHK:
+	case NETLINK_GET_STRICT_CHK:
 		if (len < sizeof(int))
 			return -EINVAL;
 		len = sizeof(int);
diff --git a/tools/include/uapi/linux/netlink.h b/tools/include/uapi/linux/netlink.h
index 486ed1f0c0bc..0a4d73317759 100644
--- a/tools/include/uapi/linux/netlink.h
+++ b/tools/include/uapi/linux/netlink.h
@@ -155,7 +155,7 @@ enum nlmsgerr_attrs {
 #define NETLINK_LIST_MEMBERSHIPS	9
 #define NETLINK_CAP_ACK			10
 #define NETLINK_EXT_ACK			11
-#define NETLINK_DUMP_STRICT_CHK		12
+#define NETLINK_GET_STRICT_CHK		12
 
 struct nl_pktinfo {
 	__u32	group;
-- 
2.19.2

Re: [PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK

From: David Ahern <hidden>
Date: 2018-12-14 19:40:37

On 12/14/18 12:38 PM, Jakub Kicinski wrote:
NETLINK_DUMP_STRICT_CHK can be used for all GET requests,
dumps as well as doit handlers.  Replace the DUMP in the
name with GET make that clearer.

Signed-off-by: Jakub Kicinski <redacted>
---
 include/uapi/linux/netlink.h       | 2 +-
 net/netlink/af_netlink.c           | 4 ++--
 tools/include/uapi/linux/netlink.h | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: David Ahern <redacted>

Re: [PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK

From: David Miller <davem@davemloft.net>
Date: 2018-12-14 19:44:46

From: David Ahern <redacted>
Date: Fri, 14 Dec 2018 12:40:34 -0700
On 12/14/18 12:38 PM, Jakub Kicinski wrote:
quoted
NETLINK_DUMP_STRICT_CHK can be used for all GET requests,
dumps as well as doit handlers.  Replace the DUMP in the
name with GET make that clearer.

Signed-off-by: Jakub Kicinski <redacted>
---
 include/uapi/linux/netlink.h       | 2 +-
 net/netlink/af_netlink.c           | 4 ++--
 tools/include/uapi/linux/netlink.h | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: David Ahern <redacted>
Applied, luckily we can still do this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help