[PATCH] vhost: correct the related warning message

Subsystems: the rest, virtio host (vhost), virtio host (vhost-scsi)

STALE2821d REVIEWED: 1 (0M)

1 review trailer.

5 messages, 3 authors, 2018-12-13 · open the first message on its own page

[PATCH] vhost: correct the related warning message

From: wangyan <hidden>
Date: 2018-12-13 01:11:09

Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
       'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'

Signed-off-by: Yan Wang <redacted>
Reviewed-by: Jun Piao <redacted>
---
 drivers/vhost/scsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 50dffe8..b459b69 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
 
 	if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
 					  &vc->out_iter))) {
-		vq_err(vq, "Faulted on copy_from_iter\n");
+		vq_err(vq, "Faulted on copy_from_iter_full\n");
 	} else if (unlikely(*vc->lunp != 1)) {
 		/* virtio-scsi spec requires byte 0 of the lun to be 1 */
 		vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);
@@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
 			se_tpg = &tpg->se_tpg;
 			ret = target_depend_item(&se_tpg->tpg_group.cg_item);
 			if (ret) {
-				pr_warn("configfs_depend_item() failed: %d\n", ret);
+				pr_warn("target_depend_item() failed: %d\n", ret);
 				kfree(vs_tpg);
 				mutex_unlock(&tpg->tv_tpg_mutex);
 				goto out;
-- 
1.8.3.1

Re: [PATCH] vhost: correct the related warning message

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2018-12-13 02:03:03

On Thu, Dec 13, 2018 at 09:10:14AM +0800, wangyan wrote:
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
       'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'

Signed-off-by: Yan Wang <redacted>
Reviewed-by: Jun Piao <redacted>
Applied, thanks!
quoted hunk
---
 drivers/vhost/scsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 50dffe8..b459b69 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
 
 	if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
 					  &vc->out_iter))) {
-		vq_err(vq, "Faulted on copy_from_iter\n");
+		vq_err(vq, "Faulted on copy_from_iter_full\n");
 	} else if (unlikely(*vc->lunp != 1)) {
 		/* virtio-scsi spec requires byte 0 of the lun to be 1 */
 		vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);
@@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
 			se_tpg = &tpg->se_tpg;
 			ret = target_depend_item(&se_tpg->tpg_group.cg_item);
 			if (ret) {
-				pr_warn("configfs_depend_item() failed: %d\n", ret);
+				pr_warn("target_depend_item() failed: %d\n", ret);
 				kfree(vs_tpg);
 				mutex_unlock(&tpg->tv_tpg_mutex);
 				goto out;
-- 
1.8.3.1

Re: [PATCH] vhost: correct the related warning message

From: Sergei Shtylyov <hidden>
Date: 2018-12-13 09:05:31

On 13.12.2018 4:10, wangyan wrote:
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
        'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove 
tf_subsystem")
Fixes: cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and 
friends")

    But no line wrapping allowed (can't find how to turn it off in my mailer).
Signed-off-by: Yan Wang <redacted>
Reviewed-by: Jun Piao <redacted>
[...]

MBR, Sergei

Re: [PATCH] vhost: correct the related warning message

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2018-12-13 15:21:28

On Thu, Dec 13, 2018 at 12:05:31PM +0300, Sergei Shtylyov wrote:
On 13.12.2018 4:10, wangyan wrote:
quoted
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
        'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
tf_subsystem")
Fixes: cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
friends")

   But no line wrapping allowed (can't find how to turn it off in my mailer).
Well is the standard really sane if people can't find a way to
follow it without being forced to use a specific mailer?

quoted
Signed-off-by: Yan Wang <redacted>
Reviewed-by: Jun Piao <redacted>
[...]

MBR, Sergei

Re: [PATCH] vhost: correct the related warning message

From: Sergei Shtylyov <hidden>
Date: 2018-12-13 20:06:27

On 12/13/2018 06:21 PM, Michael S. Tsirkin wrote:
quoted
quoted
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
        'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Fixes: d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
tf_subsystem")
Fixes: cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
friends")

   But no line wrapping allowed (can't find how to turn it off in my mailer).
Well is the standard really sane if people can't find a way to
follow it without being forced to use a specific mailer?
   Hum, my mail looked correct, although I wasn't able to get the editor to NOT
wrap my lines. Go figure... :-)
quoted
quoted
Signed-off-by: Yan Wang <redacted>
Reviewed-by: Jun Piao <redacted>
[...]
MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help