[PATCH bpf-next] bpf: arm64: Enable arm64 jit to provide bpf_line_info

Subsystems: arm64 port (aarch64 architecture), bpf jit for arm64, bpf [general] (safe dynamic programs and tools), the rest

STALE2820d

4 messages, 2 authors, 2018-12-12 · open the first message on its own page

[PATCH bpf-next] bpf: arm64: Enable arm64 jit to provide bpf_line_info

From: Martin KaFai Lau <hidden>
Date: 2018-12-12 00:02:15

This patch enables arm64's bpf_int_jit_compile() to provide
bpf_line_info by calling bpf_prog_fill_jited_linfo().

Signed-off-by: Martin KaFai Lau <redacted>
---
 arch/arm64/net/bpf_jit_comp.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
index 0a7371a86139..1542df00b23c 100644
--- a/arch/arm64/net/bpf_jit_comp.c
+++ b/arch/arm64/net/bpf_jit_comp.c
@@ -932,6 +932,7 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
 	prog->jited_len = image_size;
 
 	if (!prog->is_func || extra_pass) {
+		bpf_prog_fill_jited_linfo(prog, ctx.offset);
 out_off:
 		kfree(ctx.offset);
 		kfree(jit_data);
-- 
2.17.1

Re: [PATCH bpf-next] bpf: arm64: Enable arm64 jit to provide bpf_line_info

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2018-12-12 01:21:10

On 12/12/2018 01:02 AM, Martin KaFai Lau wrote:
This patch enables arm64's bpf_int_jit_compile() to provide
bpf_line_info by calling bpf_prog_fill_jited_linfo().

Signed-off-by: Martin KaFai Lau <redacted>
Applied, thanks! Given the change is rather small, could you also follow-up
for the other JITs (if you don't have access to test infra, the related
maintainers should be able to help you out here)?

Thanks,
Daniel

Re: [PATCH bpf-next] bpf: arm64: Enable arm64 jit to provide bpf_line_info

From: Martin Lau <hidden>
Date: 2018-12-12 04:45:40

On Wed, Dec 12, 2018 at 02:21:08AM +0100, Daniel Borkmann wrote:
On 12/12/2018 01:02 AM, Martin KaFai Lau wrote:
quoted
This patch enables arm64's bpf_int_jit_compile() to provide
bpf_line_info by calling bpf_prog_fill_jited_linfo().

Signed-off-by: Martin KaFai Lau <redacted>
Applied, thanks! Given the change is rather small, could you also follow-up
for the other JITs (if you don't have access to test infra, the related
maintainers should be able to help you out here)?
Although I haven't looked at all ARCH's jits,  I will try to post the ones
that has an obvious change like this patch. :)

The next one probably will be sparc.

Re: [PATCH bpf-next] bpf: arm64: Enable arm64 jit to provide bpf_line_info

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2018-12-12 09:53:02

On 12/12/2018 05:45 AM, Martin Lau wrote:
On Wed, Dec 12, 2018 at 02:21:08AM +0100, Daniel Borkmann wrote:
quoted
On 12/12/2018 01:02 AM, Martin KaFai Lau wrote:
quoted
This patch enables arm64's bpf_int_jit_compile() to provide
bpf_line_info by calling bpf_prog_fill_jited_linfo().

Signed-off-by: Martin KaFai Lau <redacted>
Applied, thanks! Given the change is rather small, could you also follow-up
for the other JITs (if you don't have access to test infra, the related
maintainers should be able to help you out here)?
Although I haven't looked at all ARCH's jits,  I will try to post the ones
that has an obvious change like this patch. :)

The next one probably will be sparc.
Sounds good, for the non-obvious ones, feel free to ping the JIT folks from
the maintainers file so they have a chance to follow-up.

Thanks,
Daniel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help