Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2 messages, 2 authors, 2018-11-19 · open the first message on its own page

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

From: Andreas Schwab <hidden>
Date: 2018-11-19 15:50:18

On Nov 19 2018, Alexandre Belloni [off-list ref] wrote:
My first intuition is that he mac driver quentin is using does
phy_connect when the interface is opened while macb is doing it at probe
time. I didn't investigate but maybe this can help :)
The phy probing of macb is very unreliable, perhaps it needs to be
rewritten.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

From: Andrew Lunn <andrew@lunn.ch>
Date: 2018-11-19 16:12:13

On Mon, Nov 19, 2018 at 04:50:14PM +0100, Andreas Schwab wrote:
On Nov 19 2018, Alexandre Belloni [off-list ref] wrote:
quoted
My first intuition is that he mac driver quentin is using does
phy_connect when the interface is opened while macb is doing it at probe
time. I didn't investigate but maybe this can help :)
The phy probing of macb is very unreliable, perhaps it needs to be
rewritten.
Hi Andreas

I still don't see why that would cause a hang.

Could you turn on lockdep and see if it reports a deadlock.

Thanks
	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help