[Patch net-next] net: remove unused skb_send_sock()

Subsystems: networking [general], the rest

STALE2841d

3 messages, 2 authors, 2018-11-17 · open the first message on its own page

[Patch net-next] net: remove unused skb_send_sock()

From: Cong Wang <hidden>
Date: 2018-11-13 12:01:22

Signed-off-by: Cong Wang <redacted>
---
 include/linux/skbuff.h |  1 -
 net/core/skbuff.c      | 13 -------------
 2 files changed, 14 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 7dcfb5591dc3..9f5bd97a26bd 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -3327,7 +3327,6 @@ int skb_splice_bits(struct sk_buff *skb, struct sock *sk, unsigned int offset,
 		    unsigned int flags);
 int skb_send_sock_locked(struct sock *sk, struct sk_buff *skb, int offset,
 			 int len);
-int skb_send_sock(struct sock *sk, struct sk_buff *skb, int offset, int len);
 void skb_copy_and_csum_dev(const struct sk_buff *skb, u8 *to);
 unsigned int skb_zerocopy_headlen(const struct sk_buff *from);
 int skb_zerocopy(struct sk_buff *to, struct sk_buff *from,
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index fcb1155a00ec..cfe5a03fbdf3 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -2366,19 +2366,6 @@ int skb_send_sock_locked(struct sock *sk, struct sk_buff *skb, int offset,
 }
 EXPORT_SYMBOL_GPL(skb_send_sock_locked);
 
-/* Send skb data on a socket. */
-int skb_send_sock(struct sock *sk, struct sk_buff *skb, int offset, int len)
-{
-	int ret = 0;
-
-	lock_sock(sk);
-	ret = skb_send_sock_locked(sk, skb, offset, len);
-	release_sock(sk);
-
-	return ret;
-}
-EXPORT_SYMBOL_GPL(skb_send_sock);
-
 /**
  *	skb_store_bits - store bits from kernel buffer to skb
  *	@skb: destination buffer
-- 
2.19.1

Re: [Patch net-next] net: remove unused skb_send_sock()

From: David Miller <davem@davemloft.net>
Date: 2018-11-16 09:23:41

From: Cong Wang <redacted>
Date: Mon, 12 Nov 2018 18:05:24 -0800
Signed-off-by: Cong Wang <redacted>
John, any plans to use this?  Looks like only skb_send_sock_lock()
currently has a user.

Re: [Patch net-next] net: remove unused skb_send_sock()

From: David Miller <davem@davemloft.net>
Date: 2018-11-17 13:47:57

From: Cong Wang <redacted>
Date: Mon, 12 Nov 2018 18:05:24 -0800
Signed-off-by: Cong Wang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help