RE: [PATCH 3/3] usb: renesas_usbhs: Remove dummy runtime PM callbacks

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Date: 2018-10-26 02:09:31
Also in: linux-i2c, linux-pm, linux-renesas-soc, linux-usb

Hi Wolfram-san,
From: Wolfram Sang, Sent: Friday, October 26, 2018 7:58 AM
<snip>
quoted
 static const struct dev_pm_ops usbhsc_pm_ops = {
 	.suspend		= usbhsc_suspend,
 	.resume			= usbhsc_resume,
Unrelated to this patch, but I wonder right now: is there a reason not
to use SET_SYSTEM_SLEEP_PM_OPS here? Shimoda-san?
I don't know why because this code is contributed from Morimoto-san.
I'm guessing this code seems to come from sh_eth.c or i2c-sh_mobile.c
and we don't have the SET_SYSTEM_SLEEP_PM_OPS macro at 2009.
Morimoto-san contributed this code at 2010, but it seems not to realize
we have such macro.

Anyway, I'll try to use SET_SYSTEM_SLEEP_PM_OPS on the renesas_usbhs driver.

Best regards,
Yoshihiro Shimoda
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help